Skip to content

Conversation

@wuyunfeng
Copy link
Member

@wuyunfeng wuyunfeng commented Jul 3, 2020

After PR #3454 was merged, we should refactor and reorganize some logic for long-term sustainable iteration for Doris On ES.
To facilitate code review,I would divided into this work to multiple PRs (some other WIP work I also need to think carefully)

This PR include:

  1. introduce SearchContext for all state we needed
  2. divide meta-sync logic into three phase
  3. modify some logic processing
  4. introduce version detect logic for future using

@wuyunfeng wuyunfeng changed the title [Doris On ES][refactor] refactor and enchanment ES sync meta logic [Doris On ES][Refactor] refactor and enchanment ES sync meta logic Jul 3, 2020
@morningman morningman added area/doris-on-es Issues or PRs related to Doris on ElasticSearch kind/refactor Issues or PRs to refactor code labels Jul 4, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jul 6, 2020
@morningman morningman merged commit 3ba38e3 into apache:master Jul 7, 2020
morningman pushed a commit that referenced this pull request Jul 7, 2020
I forget push some UT test in this PR #4012.
Also remove `_cluster/state` resource because DOE does not rely the full ES cluster state meta.
morningman pushed a commit to morningman/doris that referenced this pull request Jul 9, 2020
…pache#4012)

After PR apache#3454 was merged, we should refactor and reorganize some logic for long-term sustainable iteration for Doris On ES.
To facilitate code review,I would divided into this work to multiple PRs (some other WIP work I also need to think carefully)

This PR include:

1. introduce SearchContext for all state we needed
2. divide meta-sync logic into three phase
3. modify some logic processing
4. introduce version detect logic for future using
morningman pushed a commit to morningman/doris that referenced this pull request Jul 9, 2020
I forget push some UT test in this PR apache#4012.
Also remove `_cluster/state` resource because DOE does not rely the full ES cluster state meta.
@EmmyMiao87 EmmyMiao87 mentioned this pull request Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/doris-on-es Issues or PRs related to Doris on ElasticSearch kind/refactor Issues or PRs to refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants